Skip to content
This repository was archived by the owner on Oct 21, 2025. It is now read-only.

Conversation

@tnewman-at-gm
Copy link

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Azure Event Hub provides Kafka protocol compatibility. This PR adds Azure Entra support to allow Kafka UI to authenticate with Event Hub with Kafka protocol using Azure Entra credentials.

Is there anything you'd like reviewers to focus on?
New Azure Entra classes and changes to the SASL configuration options on the front end.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary) - Created an Event Hub in the Premium Tier with Kafka Enabled. Verified sending and receiving messages.
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES) - Yes, check out Azure Entra Support kafbat/ui-docs#18
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
image

@dj5483 dj5483 self-assigned this Aug 27, 2024
Copy link

@dj5483 dj5483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tnewman-at-gm tnewman-at-gm merged commit 9c6ebfd into generalmotors:Feature/Azure-entra Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants